Skip to content

Remove unnecessary installations for linux CPU test #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 13, 2025

Conversation

samanklesaria
Copy link
Collaborator

@samanklesaria samanklesaria commented Aug 12, 2025

Tests should no longer have external dependencies beyond scipy, numpy, pytorch, and testing utilities like parameterized. This PR removes the installation of dependencies beyond these when running CI.

Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4037

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending, 8 Unrelated Failures

As of commit ec301d8 with merge base bc3de07 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 12, 2025
@samanklesaria
Copy link
Collaborator Author

We have to merge #4031 first.

@samanklesaria
Copy link
Collaborator Author

It seems that CTC Decoder requires flashlight-text package, which it depends on pretty heavily. We could disable the tests for it.

test_librispeech_lightning and test_mustc_lightning and test_tedlium3_lightning require lightning. It seems these just test lightning integration (which we're deprecating anyway), so we should be able to delete these tests.

tacotron2/test_text_preprocessing.py requires unidecode. But we're only testing on ascii text. Would could give text_to_sequence a flag for whether or not to use unidecode? Or we could just add a warning to it saying that only ascii input is allowed?

I'm still not sure how much we're testing the use of inflect, which is also used in tacotron2/test_text_preprocessing.py. Perhaps we can restrict our testing to examples that don't require it, and not load the module until it is needed.

@NicolasHug
Copy link
Member

OK, thanks. Let's just skip all of those by setting the appropriate env variable e.g. TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_CTC_DECODER=1.

@samanklesaria samanklesaria marked this pull request as ready for review August 13, 2025 19:18
@samanklesaria samanklesaria requested a review from a team as a code owner August 13, 2025 19:18
@samanklesaria samanklesaria merged commit 1ccac0e into main Aug 13, 2025
40 of 43 checks passed
@samanklesaria samanklesaria deleted the remove_test_installs branch August 13, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants